Rewrite in typescript #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imranbarbhuiya
force-pushed
the
master
branch
from
1dc616c to
c9449e3
Compare
|
I've tested the changes and everything seems working fine again. I've updated version to 0.0.14 also updated changelog. |
apal21
reviewed
Nov 7, 2021
imranbarbhuiya
changed the title
imranbarbhuiya
changed the title
- rewritten in typescript - used react functional component
added github tests for lint and build updated npmignore file added esm export
imranbarbhuiya
force-pushed
the
master
branch
from
aa35e49 to
56da561
Compare
|
@apal21 review the pr when you get time. |
|
Thanks @imranbarbhuiya for this PR. Hey @apal21, any updates regarding this PR? |
|
@Shahzad6077 will approve and merge it once I test it on the previous next.js versions. @imranbarbhuiya thanks for the changes. |
imranbarbhuiya
force-pushed
the
master
branch
2 times, most recently
from
5b17332 to
cdb9542
Compare
imranbarbhuiya
force-pushed
the
master
branch
from
cdb9542 to
59709e3
Compare
imranbarbhuiya
force-pushed
the
master
branch
from
7f5ba37 to
55e7377
Compare
apal21
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm rewriting this package in typescript.
npm linkYou may find error while trying to test using
npm linkcheck https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react to fix it, but the code is correct.