Skip to content

Conversation

kezhuw
Copy link
Member

@kezhuw kezhuw commented Aug 16, 2025

This is a fixup commit to #2292. It contains only test code changes to make SSL related classes, e.g. Ca, Cert and etcd., to be reusable.

This is a fixup commit to apache#2292. It contains only test code changes to
make SSL related classes, e.g. Ca, Cert and etcd., to be reusable.
@kezhuw
Copy link
Member Author

kezhuw commented Aug 26, 2025

@anmolnar Would you like to take a look at this ? It is a fixup commit to #2292(ZOOKEEPER-4955) and touchs only test codes.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes perfect sense to make this framework reusable. Have you generated it with some AI?

@anmolnar anmolnar merged commit 45b49a5 into apache:master Aug 27, 2025
16 checks passed
@kezhuw
Copy link
Member Author

kezhuw commented Aug 27, 2025

Have you generated it with some AI?

No. But I do use IntelliJ IDEA in this refactoring, not sure whether the code completions/suggestions(line by line, it will recommend you public CertSigner withExpiration(Duration expiration) {} or this.expiration = expiration;) are backed by AI.

@anmolnar
Copy link
Contributor

Have you generated it with some AI?

No. But I do use IntelliJ IDEA in this refactoring, not sure whether the code completions/suggestions(line by line, it will recommend you public CertSigner withExpiration(Duration expiration) {} or this.expiration = expiration;) are backed by AI.

I dunno, but it's pretty impressive how quickly you were able to create the framework. Borrowed from other project or wrote from scratch?

@kezhuw
Copy link
Member Author

kezhuw commented Aug 28, 2025

Borrowed from other project or wrote from scratch?

From scratch. But I do write tls related tests code in rust, they probably have something in common despite the language.

https://github.com/kezhuw/zookeeper-client-rust/blob/4ae35472bf8545ee3462aaf287e9359ae8953644/src/tls/client.rs#L211

kezhuw added a commit to kezhuw/zookeeper that referenced this pull request Sep 30, 2025
Reviewers: anmolnar
Author: kezhuw
Closes apache#2300 from kezhuw/ZOOKEEPER-4955-addendum-refactor-test-helpers
kezhuw added a commit to kezhuw/zookeeper that referenced this pull request Oct 1, 2025
Reviewers: anmolnar
Author: kezhuw

Closes apache#2300 from kezhuw/ZOOKEEPER-4955-addendum-refactor-test-helpers

(cherry picked from 45b49a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants