Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2541] Sync golang.org/x/crypto version #136

Closed
wants to merge 1 commit into from

Conversation

targetoee
Copy link
Contributor

What is this PR for?

After k8shim updated golang.org/x/net module (apache/yunikorn-k8shim#822), the golang.org/x/crypto module is automatically updated by go mod tidy.
Therefore, this PR updates it to ensure that the versions of all three project are consistent.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - core and k8shim should be updated also.

What is the Jira issue?

YUNIKORN-2541

How should this be tested?

Screenshots (if appropriate)

N/A

Questions:

N/A

@chenyulin0719
Copy link
Contributor

Waiting for confirmation from @craigcondit and @wilfred-s to ensure we are on the same page regarding go.mod management.

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We keep our versions in the replace up to date. We try to keep the versions in sync between repos as much as we can. Sometimes we get out of sync which gets rectified at least just before we branch.

pbacsko pushed a commit that referenced this pull request May 3, 2024
Update golang.org/x/crypto to v0.21.0 to keep our versions in the replace up to date.

Closes: #136

Signed-off-by: Yu-Lin Chen <chenyulin0719@apache.org>
(cherry picked from commit b700819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants