-
Notifications
You must be signed in to change notification settings - Fork 146
Remove extra text from license #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The Apache 2.0 license on the website shows that it ends after "END OF TERMS AND CONDITIONS" https://www.apache.org/licenses/LICENSE-2.0 <img width="1401" alt="387383537-f56c8594-5c32-41d5-a5b7-f4a587125ca2" src="https://github.com/user-attachments/assets/ca29c9a4-b520-401f-9e6c-ce2b3464e942"> This text exists because it's been mistakenly copied and pasted from https://www.apache.org/licenses/LICENSE-2.0.txt where it includes placeholder text and the intent seems to be reproducing the application instructions as seen on https://www.apache.org/licenses/LICENSE-2.0 rather than as text that's intended to be included in the license. The text removed in this PR diverges slightly from the text on https://www.apache.org/licenses/LICENSE-2.0#apply > How to apply the Apache License to your work > > Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file that references the License. > > To apply the Apache License to specific files in your work, attach the following boilerplate declaration, replacing the fields enclosed by brackets "[]" with your own identifying information. (Don't include the brackets!) Enclose the text in the appropriate comment syntax for the file format. We also recommend that you include a file or class name and description of purpose on the same "printed page" as the copyright notice for easier identification within third-party archives. The text on the website ⬆️ seems to indicate that placing the Apache 2.0 license text in a `LICENSE` is sufficient for a project. The text given in the text file ⬇️ does not mention a LICENSE file and instead seems to imply that the full text of the Apache 2.0 license is not required, but use the "boilerplate" after swapping out the placeholders. Looking at other high profile projects that use the Apache 2.0 license it looks like their understanding matches mine, here's Rust https://github.com/rust-lang/rust/blob/fda68927475070696fcc9d1f5c9c990f0e1af87a/LICENSE-APACHE. Here's a discussion from 5 years ago on whether to remove the appendix from there rust-lang/rust#67734.
Please create JIRA first and then open a PR linked to that JIRA with [YUNIKORN-xxxx] as the start of the commit message. See the how to contribute guide on the website. |
Sorry about that I did a quick grep for "contributing" looking for a CONTRIBUTING.md and got no hits and missed the bit at the bottom of the README.md. I requested JIRA access, I'm now pending approval:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
+ Coverage 67.99% 68.02% +0.03%
==========================================
Files 70 70
Lines 9195 9195
==========================================
+ Hits 6252 6255 +3
+ Misses 2735 2733 -2
+ Partials 208 207 -1 ☔ View full report in Codecov by Sentry. |
Hi @schneems, I've added you as a contributor to the YuniKorn project. Sorry this took so long. Also, we appear to need this change in all our repos: yunikorn-k8shim, yunikorn-core, yunikorn-web, yunikorn-scheduler-interface, and yunikorn-release (both top-level and in release-top-level-artifacts/LICENSE). Can you please create a JIRA and attach PRs for all the repos? |
@schneems any progress with this? |
The Apache 2.0 license on the website shows that it ends after "END OF TERMS AND CONDITIONS" https://www.apache.org/licenses/LICENSE-2.0
This text exists because it's been mistakenly copied and pasted from https://www.apache.org/licenses/LICENSE-2.0.txt where it includes placeholder text and the intent seems to be reproducing the application instructions as seen on https://www.apache.org/licenses/LICENSE-2.0 rather than as text that's intended to be included in the license.
The text removed in this PR diverges slightly from the text on https://www.apache.org/licenses/LICENSE-2.0#apply
The text on the website ⬆️ seems to indicate that placing the Apache 2.0 license text in a
LICENSE
is sufficient for a project. The text given in the text file ⬇️ does not mention a LICENSE file and instead seems to imply that the full text of the Apache 2.0 license is not required, but use the "boilerplate" after swapping out the placeholders.Looking at other high profile projects that use the Apache 2.0 license it looks like their understanding matches mine, here's Rust https://github.com/rust-lang/rust/blob/fda68927475070696fcc9d1f5c9c990f0e1af87a/LICENSE-APACHE. Here's a discussion from 5 years ago on whether to remove the appendix from there rust-lang/rust#67734. And here's an ASF project that merged a similar change: