Skip to content

Conversation

@zuston
Copy link
Member

@zuston zuston commented Feb 9, 2026

What changes were proposed in this pull request?

  1. Introduce option for stale assignment fast-switch. After having this, we could better to inspect some bugs if this mechanism is caused
  2. Ignore retry count checking for stale assignment to fix the multi server switch

Why are the changes needed?

for #2725

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests

@zuston
Copy link
Member Author

zuston commented Feb 9, 2026

cc @roryqi

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Test Results

 3 175 files  ±0   3 175 suites  ±0   6h 51m 25s ⏱️ -15s
 1 241 tests ±0   1 240 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 734 runs  ±0  15 719 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit ff1b9e9. ± Comparison against base commit 1f809ed.

♻️ This comment has been updated with latest results.

@zuston zuston requested a review from roryqi February 10, 2026 02:29
@roryqi
Copy link
Contributor

roryqi commented Feb 10, 2026

Is it a fallback mechanism?

@zuston
Copy link
Member Author

zuston commented Feb 10, 2026

Is it a fallback mechanism?

bug fix

@zuston
Copy link
Member Author

zuston commented Feb 10, 2026

Although the existing tests cover most scenarios in this PR, it’s difficult to simulate this specific case. After the PR #2727 introduces the ReassignExecutor, I will add dedicated tests for this PR. cc @roryqi

@roryqi
Copy link
Contributor

roryqi commented Feb 10, 2026

Is it a fallback mechanism?

bug fix

Why do we need a config option if this is a bug fix?

@zuston
Copy link
Member Author

zuston commented Feb 10, 2026

Is it a fallback mechanism?

bug fix

Why do we need a config option if this is a bug fix?

This has been described in the description.

@roryqi
Copy link
Contributor

roryqi commented Feb 10, 2026

  1. inspect

The description says that this is a feature to find bugs easily instead of a bug.

@roryqi
Copy link
Contributor

roryqi commented Feb 10, 2026

  1. inspect

The description says that this is a feature to find bugs easily instead of a bug.

I got it. This pull request includes one feature and one fix.

@zuston zuston merged commit eb53a1a into apache:master Feb 10, 2026
41 checks passed
@zuston zuston deleted the fixassign branch February 10, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants