[microNPU] Fix bug with re-reading in EncodeConstants #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
mbaret
requested review from
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
Thanks @mbaret ! This is merged now! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixed the pass so it handles it correctly. Change-Id: I6f54cdb7be69428e49c3b4208271cd3e6c192e5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a striping strategy that leads to weights being re-read was deployed, the logic in EncodeConstants failed. This adds a test for that case and fixes the pass so it handles it correctly.