Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Non-recursive dependency graph #9528

Merged
merged 2 commits into from
Dec 13, 2021
Merged

[Relay] Non-recursive dependency graph #9528

merged 2 commits into from
Dec 13, 2021

Conversation

hzfan
Copy link
Contributor

@hzfan hzfan commented Nov 18, 2021

Relay IR printer suffers from stack overflow when the graph is too large. This PR cherry-picks #8434 to make it non-recursive.

cc @mbrookhart @comaniac @yzhliu

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
cc @mbrookhart

@comaniac
Copy link
Contributor

btw please fix the CI

@hzfan hzfan force-pushed the nonrecur branch 2 times, most recently from 499fc45 to c5c3ba4 Compare December 12, 2021 10:20
@mbrookhart
Copy link
Contributor

Looks like you hit a flakey out of disk on one of the nodes, can you retry CI?

@hzfan
Copy link
Contributor Author

hzfan commented Dec 12, 2021

Retriggered but the out of disk persists...will try again later

@hzfan hzfan force-pushed the nonrecur branch 4 times, most recently from 320cf93 to 3a2f7e8 Compare December 13, 2021 04:29
@comaniac comaniac merged commit a674121 into apache:main Dec 13, 2021
@comaniac
Copy link
Contributor

Thanks @hzfan @mbrookhart

ccjoechou pushed a commit to ccjoechou/tvm that referenced this pull request Dec 13, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants