[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close #9500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
kparzysz-quic,
leandron,
liangfu,
manupak,
masahi,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tmoreau89,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Mousius
changed the title
Mousius
force-pushed
the
device-api-activate
branch
from
fb75858 to
c88bb17
Compare
This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
Mousius
force-pushed
the
device-api-activate
branch
from
c88bb17 to
4dbe678
Compare
Mousius
commented
Nov 15, 2021
Mousius
force-pushed
the
device-api-activate
branch
from
a69a7ac to
36042e4
Compare
gromero
reviewed
Nov 16, 2021
|
|
||
| def representative_dataset(): | ||
| for _ in range(100): | ||
| data = np.random.rand(*tuple([1, 3, 4, 3])) |
Contributor
There was a problem hiding this comment.
@Mousius Could the unpack here be directly from the list? Like: ...rand(*[1, 3, 4, 3])?
Member
Author
There was a problem hiding this comment.
Oh, nice spot @gromero, by the same token I don't think we even need to unpack the list? This is the same as rand(1, 3, 4,3), I'll clear this up 😸
Contributor
There was a problem hiding this comment.
@Mousius Hi! Yeah, I thought of that too (avoiding the unpack too), however I assumed you would like to keep it as [1, 3, 4, 3] just to be "more explicit" by keeping the dimensions written in a form as you pass later for example to tf.TensorSpec. Either way looks fine to me, just the form with "tuple" seems superfluous :)
areusch
approved these changes
Nov 16, 2021
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
@mbs-octoml can you take a look too?
Contributor
|
@manupa-arm can you take another look? |
Contributor
|
Lets follow up with any outstanding comments in 3/3. @gromero @mbs-octoml |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…pache#9500) * [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md) * Standardise on `lowered_ir_mods` and correct device_hook variable name
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…pache#9500) * [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md) * Standardise on `lowered_ir_mods` and correct device_hook variable name
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…pache#9500) * [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md) * Standardise on `lowered_ir_mods` and correct device_hook variable name
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
…pache#9500) * [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md) * Standardise on `lowered_ir_mods` and correct device_hook variable name
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…pache#9500) * [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close This adds the relevant hooks into their starting places in the code generation. As per the [C Device API RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md) * Standardise on `lowered_ir_mods` and correct device_hook variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the relevant hooks into their starting places in the code generation. As per the C Device API RFC
This stacks on top of #9395