[Relay] Non-recursive Dtor for Let #9461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzfan
requested review from
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
hzfan
changed the title
comaniac
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
LGTM.
This PR is similar to the previous one (#7832) that makes deconstructing Call nodes non-recursive.
Also cc @mbrookhart
|
FYI, I had almost exactly this code in here: #8434 And then I got dragged away to other problems and never fixed the un-related bugs in other changes I made :D :( |
|
@mbrookhart Would you mind if I port the |
|
Please, take whatever you want, I never got back to figuring out which of the changes I made ended up causing CI errors. |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* non-recursive let desctruction * fix serialization * Fix serialization * lint * lint * lint * add tests for serial/deserial * lint Co-authored-by: Haozheng Fan <hzfan@apache.com>
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* non-recursive let desctruction * fix serialization * Fix serialization * lint * lint * lint * add tests for serial/deserial * lint Co-authored-by: Haozheng Fan <hzfan@apache.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* non-recursive let desctruction * fix serialization * Fix serialization * lint * lint * lint * add tests for serial/deserial * lint Co-authored-by: Haozheng Fan <hzfan@apache.com>
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* non-recursive let desctruction * fix serialization * Fix serialization * lint * lint * lint * add tests for serial/deserial * lint Co-authored-by: Haozheng Fan <hzfan@apache.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* non-recursive let desctruction * fix serialization * Fix serialization * lint * lint * lint * add tests for serial/deserial * lint Co-authored-by: Haozheng Fan <hzfan@apache.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructor for Let overflows when the graph size grows. This PR replaces the recursive destructor with non-recursive one.
cc @yzhliu @comaniac