Skip to content

[TEST] Disable Hexagon TestConv2dPackedFilter test #9344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

[TEST] Disable Hexagon TestConv2dPackedFilter test #9344

merged 1 commit into from
Oct 22, 2021

Conversation

@masahi
Copy link
Member

@masahi masahi commented Oct 21, 2021 •
edited
Loading

@masahi masahi changed the title Disable Hexagon TestConv2dPackedFilter test [TEST] Disable Hexagon TestConv2dPackedFilter test Oct 21, 2021
@masahi masahi mentioned this pull request Oct 21, 2021
Merged
csullivan
csullivan approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not clear if this test is exposing an issue in the docker config for i386 and this is the unlucky test, or if it is an issue with the test. Unfortunately we are having difficulty reproducing with the i386 docker locally. Let's skip the test to unblock merge while we try to repro.

@mbs-octoml
Copy link
Contributor

mbs-octoml commented Oct 21, 2021

(See TVMCI-8 on the OctoML JIRA)

@grant-arm
Copy link
Contributor

grant-arm commented Oct 22, 2021

This issue is blocking 2 of my PRs in CI as well:
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9323/3/pipeline/270
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9307/4/pipeline

@manupak
Copy link
Contributor

manupak commented Oct 22, 2021

I am also seeing this : https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9214/3/pipeline/.

Seem like, we broadly agree to disable it for now to unblock.

manupak
manupak approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@manupak manupak merged commit d5dd8c0 into apache:main Oct 22, 2021
@manupak
Copy link
Contributor

manupak commented Oct 22, 2021

This is merged! Thanks! @masahi @mbs-octoml @csullivan @grant-arm

AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Oct 25, 2021
@AndrewZhaoLuo
Merge branch 'aluo/qnn/conv2d-transpose-fixes' of github.com:AndrewZh…
be20086 
…aoLuo/tvm into aluo/qnn/conv2d-transpose-fixes

* 'aluo/qnn/conv2d-transpose-fixes' of github.com:AndrewZhaoLuo/tvm: (27 commits)
  fix keras
  jostle
  more frontend tests fixes
  remove f2qi for later pr
  remove formatting only change
  undo just formatting changes
  lint
  add todo
  fix fake quantization pass
  fix qnn conv2d transpose tests
  fix vitis tests
  change layouts for conv2d_transpose too
  fix bug with layout transform
  add test
  lint
  make pytorch tests pass
  fix a lot of initial tests
  Disable Hexagon TestConv2dPackedFilter test (apache#9344)
  BUG: Look through on_device annotations when looking for shape constants (apache#9345)
  [Community] @ganler -> Reviewer (apache#9346)
  ...
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@masahi @ylc
Disable Hexagon TestConv2dPackedFilter test (apache#9344)
fd06adf
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@masahi @ylc
Disable Hexagon TestConv2dPackedFilter test (apache#9344)
abaad9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csullivan csullivan csullivan approved these changes

@manupak manupak manupak approved these changes

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@masahi @mbs-octoml @grant-arm @manupak @csullivan