[RPC] Fix Server connecting to RPC Tracker through a Proxy #9210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KJlaccHoeUM9l
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
tqchen
reviewed
Oct 8, 2021
|
|
||
| client = rpc.connect_tracker(tracker_server.host, tracker_server.port) | ||
| summary = client.summary() | ||
| assert summary["queue_info"][device_key]["free"] == 2 |
There was a problem hiding this comment.
relying on sleep can be unreliable and cause flaky errors(as in many past cases). Can we just not assert the query part and make sure connection to tracker is covered
|
Thanks @KJlaccHoeUM9l . made a minor comment on test |
KJlaccHoeUM9l
force-pushed
the
agladyshev/pr/rpc/tracker_via_proxy
branch
from
bbcf0cf
to
36c4092
Compare
tqchen
approved these changes
Oct 11, 2021
|
Thank you @KJlaccHoeUM9l ! |
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Server connecting to RPC Tracker through a Proxy which was broken. Additionally, a test has been added to check this type of connection in regular CI.