[microTVM] Remove Arduino aot code

apps/microtvm/arduino/example_project/src/model.c

@@ -20,11 +20,11 @@
 #include "model.h"
 
 #include "Arduino.h"
+#include "standalone_crt/include/dlpack/dlpack.h"
 #include "standalone_crt/include/tvm/runtime/crt/stack_allocator.h"
 
 // AOT memory array
 static uint8_t g_aot_memory[WORKSPACE_SIZE];
-extern tvm_model_t tvmgen_default_network;
 tvm_workspace_t app_workspace;
 
 // Blink code for debugging purposes

apps/microtvm/arduino/host_driven/src/model_support.c

@@ -17,6 +17,8 @@
  * under the License.
  */
 
+#include "standalone_crt/include/dlpack/dlpack.h"
+#include "standalone_crt/include/tvm/runtime/crt/error_codes.h"
 #include "stdarg.h"
 
 // Blink code for debugging purposes

apps/microtvm/arduino/template_project/microtvm_api_server.py

@@ -365,7 +365,7 @@ def build(self, options):
             compile_cmd.append("--verbose")
 
         # Specify project to compile
-        subprocess.run(compile_cmd)
+        subprocess.run(compile_cmd, check=True)
 
     BOARD_LIST_HEADERS = ("Port", "Type", "Board Name", "FQBN", "Core")
 
@@ -402,7 +402,9 @@ def _parse_boards_tabular_str(self, tabular_str):
 
     def _auto_detect_port(self, options):
         list_cmd = [options["arduino_cli_cmd"], "board", "list"]
-        list_cmd_output = subprocess.run(list_cmd, stdout=subprocess.PIPE).stdout.decode("utf-8")
+        list_cmd_output = subprocess.run(
+            list_cmd, check=True, stdout=subprocess.PIPE
+        ).stdout.decode("utf-8")
 
         desired_fqbn = self._get_fqbn(options)
         for line in self._parse_boards_tabular_str(list_cmd_output):
@@ -439,7 +441,7 @@ def flash(self, options):
         if options.get("verbose"):
             upload_cmd.append("--verbose")
 
-        subprocess.run(upload_cmd)
+        subprocess.run(upload_cmd, check=True)
 
     def open_transport(self, options):
         # Zephyr example doesn't throw an error in this case

tests/micro/arduino/test_arduino_workflow.py

@@ -19,12 +19,14 @@
 import pathlib
 import shutil
 import sys
+import tempfile
 
 import pytest
-import tvm
-from tvm import micro, relay
 
 import conftest
+import tvm
+from tvm import micro, relay
+from tvm.micro.project_api.server import ServerError
 
 """
 This unit test simulates a simple user workflow, where we:
@@ -49,6 +51,30 @@ def project_dir(workspace_dir):
     return workspace_dir / "project"
 
 
+# Saves the Arduino project's state, runs the test, then resets it
+@pytest.fixture(scope="function")
+def does_not_affect_state(project_dir):
+    with tempfile.TemporaryDirectory() as temp_dir:
+        prev_project_state = pathlib.Path(temp_dir)
+        shutil.copytree(project_dir, prev_project_state / "project")
+        yield
+
+        # We can't delete project_dir or it'll mess up the Arduino CLI working directory
+        # Instead, delete everything in project_dir, and then copy over the files
+        for item in project_dir.iterdir():
+            if item.is_dir():
+                shutil.rmtree(item)
+            else:
+                item.unlink()  # Delete file
+        # Once we upgrade to Python 3.7, this can be replaced with
+        # shutil.copytree(dirs_exist_ok=True)
+        for item in (prev_project_state / "project").iterdir():
+            if item.is_dir():
+                shutil.copytree(item, project_dir / item.name)
+            else:
+                shutil.copy2(item, project_dir)
+
+
 def _generate_project(arduino_board, arduino_cli_cmd, workspace_dir, mod, build_config):
     return tvm.micro.generate_project(
         str(conftest.TEMPLATE_PROJECT_DIR),
@@ -135,6 +161,20 @@ def test_import_rerouting(project_dir, project):
         assert "include/tvm/runtime/crt/platform.h" in c_backend_api_c
 
 
+@pytest.mark.usefixtures("does_not_affect_state")
+def test_blank_project_compiles(project):
+    project.build()
+
+
+# Add a bug (an extra curly brace) and make sure the project doesn't compile
+@pytest.mark.usefixtures("does_not_affect_state")
+def test_bugged_project_compile_fails(project_dir, project):
+    with open(project_dir / "project.ino", "a") as main_file:
+        main_file.write("}\n")
+    with pytest.raises(ServerError):
+        project.build()
+
+
 # Build on top of the generated project by replacing the
 # top-level .ino fileand adding data input files, much
 # like a user would