Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetaSchedule][M3a] Traced Schedule #8623

Merged
merged 1 commit into from
Aug 9, 2021
Merged

[MetaSchedule][M3a] Traced Schedule #8623

merged 1 commit into from
Aug 9, 2021

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Aug 2, 2021 •
edited
Loading

This PR is part of the meta schedule upstreaming work #8473, which enables a schedule class to trace the instructions executed so far.

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

@junrushao junrushao mentioned this pull request Aug 2, 2021
Closed
62 tasks
MasterJH5574
MasterJH5574 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

include/tvm/tir/schedule/schedule.h Outdated Show resolved Hide resolved
@junrushao
Copy link
Member Author

junrushao commented Aug 3, 2021 •
edited
Loading

CC @electriclilies @tkonolige @jroesch @jwfromm @areusch @jcf94 @comaniac @merrymercy

comaniac
comaniac approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only miner nits.

include/tvm/tir/schedule/schedule.h Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Show resolved Hide resolved
tkonolige
tkonolige requested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. A couple of nits.

python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
include/tvm/tir/schedule/schedule.h Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
electriclilies
electriclilies reviewed Aug 4, 2021
View reviewed changes
Copy link
Contributor

@electriclilies electriclilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions

python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Show resolved Hide resolved
@comaniac
Copy link
Contributor

comaniac commented Aug 6, 2021

@junrushao1994 please update the debug mode per discussion and we can merge this PR.

@junrushao
Copy link
Member Author

CC @icemelon

@junrushao
Copy link
Member Author

According to our discussion, I made the following changes:

  • "debug_mode" is changed to "debug_mask"
  • On the python side, "debug_mask" is changed to "all" or "none" or an integer mask, from True/False/integer mask

@junrushao @Hzfengsy
@spectrometerHBH @MasterJH5574 @jinhongyii @vinx13
[Meta Schedule][M3a] Traced Schedule
6de1861 
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
tkonolige
tkonolige approved these changes Aug 9, 2021
View reviewed changes
src/tir/schedule/traced_schedule.h
Comment on lines +57 to +58
/******** Schedule: Manipulate ForKind ********/
/******** Schedule: Insert cache stages ********/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these to be filled in later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and they will be filled up very soon in subsequent PRs

@comaniac comaniac merged commit 3145867 into apache:main Aug 9, 2021
@comaniac
Copy link
Contributor

comaniac commented Aug 9, 2021

Thanks everyone. This is merged.

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Aug 11, 2021
@junrushao @Hzfengsy
@spectrometerHBH @MasterJH5574 @jinhongyii @vinx13 @mehrdadh
[Meta Schedule][M3a] Traced Schedule (apache#8623)
ada181f 
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@junrushao @Hzfengsy
@spectrometerHBH @MasterJH5574 @jinhongyii @vinx13 @ylc
[Meta Schedule][M3a] Traced Schedule (apache#8623)
89bd421 
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@junrushao @Hzfengsy
@spectrometerHBH @MasterJH5574 @jinhongyii @vinx13 @ylc
[Meta Schedule][M3a] Traced Schedule (apache#8623)
7a707a1 
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
@junrushao junrushao changed the title [Meta Schedule][M3a] Traced Schedule [MetaSchedule][M3a] Traced Schedule Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electriclilies electriclilies electriclilies left review comments

@tkonolige tkonolige tkonolige approved these changes

@tqchen tqchen tqchen approved these changes

@comaniac comaniac comaniac approved these changes

@jcf94 jcf94 jcf94 approved these changes

@MasterJH5574 MasterJH5574 MasterJH5574 approved these changes

@areusch areusch Awaiting requested review from areusch

@jroesch jroesch Awaiting requested review from jroesch

@kparzysz-quic kparzysz-quic Awaiting requested review from kparzysz-quic

@masahi masahi Awaiting requested review from masahi

@merrymercy merrymercy Awaiting requested review from merrymercy

@vinx13 vinx13 Awaiting requested review from vinx13

@yzhliu yzhliu Awaiting requested review from yzhliu

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees

@comaniac comaniac

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@junrushao @comaniac @tkonolige @tqchen @jcf94 @electriclilies @MasterJH5574