FoldScaleAxis became non-recursive #8325
Conversation
FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1
|
bump. also cc @tqchen |
|
Sorry! Not sure how I lost this. I don't fully understand this pass, and it seems you've made some more complicated changes above moving it to mixed mode? I would appriciate @tqchen's review, since it was originally his code. |
|
Would be great if @vinx13 can also help to take a look |
There is an extra minor change related to not doing the optimization if there were no messages produced by preparation sub-passes. |
|
bump |
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
I'm happy with the mixed mode parts, but I'd still love to get @vinx13's eyes on it.
|
@d-smirnov There are some irrelevant errors on CI, Could you try again to get CI passed? Thanks |
Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
d-smirnov
force-pushed
the
fold_scale_axis
branch
from
5f0bc5d to
383c2a1
Compare
|
Thanks @d-smirnov @vinx13 @tqchen |
* FoldScaleAxis became non-recursive FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1 * Added extra empty lines as requested Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
* FoldScaleAxis became non-recursive FoldScaleAxis moved from ExprVisitor and ExprMutator to non-recursive MixedModeVisitor and MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is non-recursive. Change-Id: I8bf40bd1f3f039ef0705c665a34a4624067048a1 * Added extra empty lines as requested Change-Id: I242ec95f92b3dfc7fa3dd89385f56ab07c6e72a8
4 participants
This PR migrates FoldScaleAxis optimization pass from ExprVisitor/ExprMutator to non-recursive MixedModeVisitor/MixedModeMutator. The specific transforming part itself is still recursive, however the underlying traversal machinery is now non-recursive.