[Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion. #8321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mbrookhart @masahi can you guys take a look at this PR? |
mbrookhart
requested changes
Jun 24, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
Nit, but needs to be changed. Otherwise looks good. I appreciate the TODO.
In general, and for what it's worth, I find the -k option in pytest easier than commenting out the test list 🤷♂️
mbrookhart
approved these changes
Jun 24, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…version. (apache#8321) * Enable group conv1d import through conv2d hack. * remove silly commented out lines.
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
…version. (apache#8321) * Enable group conv1d import through conv2d hack. * remove silly commented out lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVM doesn't support
group_conv1dcurrently and adding it formally is a non-trivial amount of work. Meanwhile, we're encountering an increasing number of models that use it. As an interim solution, we can importgroup_conv1dusinggroup_conv2dby simply adding a new spatial axis with size 1. This PR adds that converter into the onnx frontend along with corresponding tests.