Skip to content

Conversation

@mehrdadh
Copy link
Member

This PR:

  • Rename all uTVM files and definitions to microTVM.

@mehrdadh
Copy link
Member Author

cc @areusch @gromero

@gromero
Copy link
Contributor

gromero commented Jun 18, 2021

Hi @mehrdadh Since I joined the project I was inclined to use (and tried to stick with) the form "uTVM". I have no strong feelings other than really sticking with only one form, hence I think that PR makes sense indeed (ppl might even write mTVM sometimes, which doesn't look good at all). I'm just wondering if I missed any discussion or thread about favoring microTVM. Either way I think using microTVM is the right choice, because uTVM is often written also using the mu symbol (Greek), which is confusing sometimes and might be difficult to type on some consoles. On Linux I also prefer typing "micro" instead of CTRL-Shift-u-b-5 :)

@mehrdadh
Copy link
Member Author

@gromero thanks for the feedback!
The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.
We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.
We could also CC people here and see if anyone has any suggestion.

@mehrdadh
Copy link
Member Author

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about something similar to this PR when I read @areusch's PR with the MLF documentation. I agree with @gromero that sticking with one form is the important bit here.

microTVM looks great to me, because it is plain and clear on what it means. It is also already in use in many parts of the docs.

There are these places also that come to mind that need to be changed (from µTVM to microTVM):

  • python/tvm/micro/contrib/zephyr.py
  • python/tvm/driver/tvmc/runner.py
  • python/tvm/driver/tvmc/compiler.py

In terms of the need or not for an RFC, I think the microTVM spelling is already in so many parts of the live documentation (e.g. https://tvm.apache.org/docs/microtvm/index.html), that makes this PR basically a fix PR, rather than an introductory PR. Based on that, I don't think we need an RFC for this.

Thanks for doing this work @mehrdadh!

@gromero
Copy link
Contributor

gromero commented Jun 20, 2021

The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.

Yeah, thanks for proposing that change.

We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.

I asked just out of curiosity. I thought of a change like that just after I joined the project so I was wondering if I missed anything recently in the open so I could check it out curiosity. I really don't think it's necessary a RFC for that change.

@Mousius
Copy link
Member

Mousius commented Jun 21, 2021

This is a great improvement @mehrdadh, I agree microTVM is the most correct as I had similar feelings towards the awkwardness of µTVM -> uTVM (and µ broke one of my scripts 😿). Thanks for proposing this 😸

One small thing that follows on from @leandron's comment is that there are also some µs hiding in NEWS.md and CONTRIBUTORS.md

@mehrdadh
Copy link
Member Author

@leandron @Mousius thanks for pointing out those files. I fixed all of them.
We still have couple of µTVM and utvm in NEWS.md which are mentioning some PRs. I haven't changed those. Here is a list of them:

We could also refactor these if someone with contributor access could help in renaming these PRs.

@mehrdadh
Copy link
Member Author

mehrdadh commented Jun 21, 2021

cc @hogepodge
It would be great to also reflect this PR in TVM doc. I'll be happy to do it if you could point me to where the doc lives.
Thanks!

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mehrdadh i agree this makes more sense.

@areusch areusch merged commit 3cb838d into apache:main Jun 22, 2021
@mehrdadh mehrdadh deleted the utvm_refactor branch July 7, 2021 16:21
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* refactor

* rename utvm_rpc_server.h

* rename file

* rename

* rename file

* rename

* variables

* directories

* format

* trigger

* more refactor

* one more

* format
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* refactor

* rename utvm_rpc_server.h

* rename file

* rename

* rename file

* rename

* variables

* directories

* format

* trigger

* more refactor

* one more

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants