[Vulkan][Codegen] Added spvValidate check after vulkan shader generation #8098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spvValidate found the bug that was fixed in apache#7966, along with a few other issues on missing capability/extension declarations. Now that all unit tests pass with it enabled, would like to enable by default.
|
Potential reviewer: @masahi |
masahi
approved these changes
May 21, 2021
|
Thanks @Lunderberg |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…ion (apache#8098) spvValidate found the bug that was fixed in apache#7966, along with a few other issues on missing capability/extension declarations. Now that all unit tests pass with it enabled, would like to enable by default. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…ion (apache#8098) spvValidate found the bug that was fixed in apache#7966, along with a few other issues on missing capability/extension declarations. Now that all unit tests pass with it enabled, would like to enable by default. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spvValidate found the bug that was fixed in #7966, along with a few
other issues on missing capability/extension declarations. Now that
all unit tests checked by the CI pass with it enabled, would like to
enable by default.