Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gpu to cuda, and bump dlpack to v0.5 #8032

Merged
merged 2 commits into from
May 13, 2021

Conversation

YuchenJin
Copy link
Contributor

@YuchenJin YuchenJin commented May 12, 2021

This PR implements the RFC: https://discuss.tvm.apache.org/t/rfc-rename-gpu-to-cuda/9928. The main purpose is to clearly distinguish between the general GPU devices and CUDA-enabled GPUs by renaming some gpu to cuda in the codebase.

  • DLPack has recently done such renaming, so this PR bumps dlpack to v0.5.
  • The API tvm.gpu(0) is changed to tvm.cuda(0), but we keep the old tvm.gpu() API for another release cycle.

@tqchen @junrushao1994

@tqchen tqchen merged commit 43c2ea7 into apache:main May 13, 2021
@tqchen
Copy link
Member

tqchen commented May 13, 2021

Thanks @YuchenJin ! This is merged. It would be great if we can also send followup API changes(gpu =>cuda) in the language frontends. The ones i see so far are:

  • java
  • rust
  • typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants