[Relay]Frontend][Onnx] Remove pop that interferes with nested loops. #7781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Apr 1, 2021
Contributor
|
Looks like the assertion that you modified is breaking CI: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7781/1/pipeline @jwfromm |
Contributor
Author
|
@tmoreau89 yeah that new assert actually triggers for inner nested loops. I've changed it to only check in the outermost scope of the model which should be the sweet spot. |
Contributor
|
Thank you @jwfromm @mbrookhart the PR has been merged. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7781) * Remove popping that interferes with nested loops. * Only check user inputs in the outer-most graph scope. * Fix style. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7781) * Remove popping that interferes with nested loops. * Only check user inputs in the outer-most graph scope. * Fix style. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…pache#7781) * Remove popping that interferes with nested loops. * Only check user inputs in the outer-most graph scope. * Fix style. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…pache#7781) * Remove popping that interferes with nested loops. * Only check user inputs in the outer-most graph scope. * Fix style. Co-authored-by: Ubuntu <jwfromm@jwfromm-cpu-dev.itxhlkosmouevgkdrmwxfbs5qh.xx.internal.cloudapp.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7699 introduced a check for user provided shapes that arent found in the input graph. My implementation used
pop, which it turns out can cause issues in nested loops. Unfortunately, its difficult to write a test case that triggers this error, but we should avoid pop in general. This PR replaces the pop based approach with a much safer way to check the same condition.