Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend][keras] Add support for TimeDistributed #7006

Merged
merged 20 commits into from
Jan 21, 2022
Merged

[frontend][keras] Add support for TimeDistributed #7006

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0c1de75
First pass on modifying Keras importer to handle TimeDistributed
slyubomirsky Nov 26, 2020
ef6475d
Use squeeze inside TimeDistributed, add tests
slyubomirsky Dec 1, 2020
869c705
linter fixes
slyubomirsky Dec 1, 2020
1816f9a
More linting
slyubomirsky Dec 1, 2020
661a808
Even more linting
slyubomirsky Dec 1, 2020
71825e2
Fix unused argument annotations
slyubomirsky Dec 2, 2020
0a79f9a
Forgot one pylint annotation
slyubomirsky Dec 2, 2020
50d1f5c
Forgot to set up data layout in _convert_activation
slyubomirsky Dec 2, 2020
901f766
Decouple data_layout from etab
slyubomirsky Dec 8, 2020
1e9f642
Linting fix
slyubomirsky Dec 8, 2020
d50375d
Forgot to set data_layout argument
slyubomirsky Dec 8, 2020
50a3230
Missed an etab.data_format, also test_conv1d was not in the test file…
slyubomirsky Dec 8, 2020
a50848f
Rebase fixes
slyubomirsky Jan 21, 2022
dd55b40
Linting fix
slyubomirsky Jan 21, 2022
b2e0413
_convert_lambda needs a data layout argument too
slyubomirsky Jan 21, 2022
2247789
linting fix too
slyubomirsky Jan 21, 2022
ffee4a9
Lint the test file too
slyubomirsky Jan 21, 2022
a2494e1
Redundant variables
slyubomirsky Jan 21, 2022
d83d8cf
Simplify further
slyubomirsky Jan 21, 2022
8ed61ae
Another simplification
slyubomirsky Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify further
  • Loading branch information
@slyubomirsky
slyubomirsky committed Jan 21, 2022
commit d83d8cfddbf6cd8f657124c720c91a0255fd94eb
4 changes: 2 additions & 2 deletions python/tvm/relay/frontend/keras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ def _convert_repeat_vector(
return out


def _convert_l2_normalize(inexpr, keras_layer, _, data_layout):
def _convert_l2_normalize(inexpr, keras_layer, data_layout):
l2_normalize_is_loaded = False
param_list = []
for i in dis.get_instructions(keras_layer.function):
Expand Down Expand Up @@ -1171,7 +1171,7 @@ def _convert_lambda(inexpr, keras_layer, etab, data_layout):
and len(fcode.co_names) > 0
and fcode.co_names[-1] == "l2_normalize"
):
return _convert_l2_normalize(inexpr, keras_layer, etab, data_layout)
return _convert_l2_normalize(inexpr, keras_layer, data_layout)
raise tvm.error.OpNotImplemented(
"Function {} used in Lambda layer is not supported in frontend Keras.".format(
fcode.co_names
Expand Down