Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONDA] Revamp conda recipe. #6732

Merged
merged 2 commits into from
Oct 24, 2020
Merged

[CONDA] Revamp conda recipe. #6732

merged 2 commits into from
Oct 24, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Oct 21, 2020

  • Combines two packages into a single recipe.
  • Enable windows build.
  • Better packaging hash tag (use git string).

@tqchen
Copy link
Member Author

tqchen commented Oct 21, 2020

cc @junrushao1994 @abergeron

@junrushao
Copy link
Member

Nice! I am a big fan of conda! Will take a look tonight!

@tqchen
[CONDA] Revamp conda recipe.
9b3393b 
- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).
junrushao
junrushao reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly some formatting nitpicks

conda/recipe/meta.yaml Show resolved Hide resolved
docker/Dockerfile.conda_cuda100 Outdated Show resolved Hide resolved
docker/Dockerfile.conda_cuda90 Outdated Show resolved Hide resolved
@tqchen
Copy link
Member Author

tqchen commented Oct 22, 2020

Thanks @junrushao1994 updated

junrushao
junrushao approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tqchen tqchen merged commit aaa9886 into apache:main Oct 24, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 29, 2020
@tqchen
[CONDA] Revamp conda recipe. (apache#6732)
053d966 
* [CONDA] Revamp conda recipe.

- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).

* Address comment
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@tqchen
[CONDA] Revamp conda recipe. (apache#6732)
be1d0f8 
* [CONDA] Revamp conda recipe.

- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).

* Address comment
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@tqchen
[CONDA] Revamp conda recipe. (apache#6732)
a22e84e 
* [CONDA] Revamp conda recipe.

- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).

* Address comment
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@tqchen @trevor-m
[CONDA] Revamp conda recipe. (apache#6732)
b789122 
* [CONDA] Revamp conda recipe.

- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).

* Address comment
@tqchen tqchen deleted the conda branch February 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqchen @junrushao