[Relay] Minor fix for some TF OD models #6729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Oct 22, 2020
| return tvm::tir::Select(condition(condition_idx) != 0, x(), y()); | ||
| PrimExpr cond; | ||
| if (condition->shape.size() == 0) { | ||
| cond = condition(); |
Member
There was a problem hiding this comment.
in this case, does cond != 0 alway hold?
Contributor
Author
There was a problem hiding this comment.
No. cond is a scalar.
zhiics
reviewed
Oct 22, 2020
python/tvm/relay/op/_transform.py
Outdated
| """ | ||
| cond_shape = inputs[0] | ||
| x_shape = inputs[1] | ||
|
|
Member
There was a problem hiding this comment.
could be just one-liner
out_shape = x_shape if x_shape.shape else cond_shape
zhiics
approved these changes
Oct 22, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 23, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Oct 23, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
codeislife99
pushed a commit
to codeislife99/incubator-tvm
that referenced
this pull request
Nov 20, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 31, 2021
* Minor fix for some tf od models * More fix * Minor fix * Fix lint * Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trevor-m @zhiics