-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING] Fix the error when running tests with default targets #6394
Conversation
Which target strings is this failing with? It seems like we want to test if the full target string is enabled with |
This happens when I directly run There is a difference between whether a target is enabled(can generate code), versus whether a runtime is available(can run). Most of the runtime enabled code only takes the For runtime availability testing, we should always use the target kind for now. We are also in the process of upgrading the Target specifications, so we might want to look into that later. But my take is that most of the cases should be about runtime availability. |
This test fails: Many of the tests used to use |
It is a bit confusing to do Because In most of the testcases we are interested right now, we are asking about whether a runtime is enabled(so we can run the generated code). I agree that we might want to improve the logic further. Or modify the testing logic, to use TVM_TESTING_RUNTIME and only include cpu/gpu/opencl/metal/ variations for now. |
That is also why in the original test cases the LLVM arm code generator tests are done in a different way(always enabled because llvm covers these cases), and we don't run the code, but instead just inspect the generated asms |
I think this change is fine. The real problem seems to be a conflation of targets and devices in a lot of the tests. I think we might also have to improve |
The previous testing.py causes problem of not being able to run the test with the default set of targets.
We might also want to update the code further to memoize the list of targets in the first run
cc @tkonolige @tmoreau89 @jroesch