-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch] Add support for split #5174
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -379,6 +379,32 @@ def test_forward_maxpool1d(): | |
stride=2).eval(), | ||
input_data) | ||
|
||
def test_forward_split(): | ||
torch.set_grad_enabled(False) | ||
input_shape = [4, 10] | ||
|
||
class Split1(Module): | ||
def forward(self, *args): | ||
return torch.split(args[0], 2, 0) | ||
|
||
class Split2(Module): | ||
def forward(self, *args): | ||
return torch.split(args[0], [2, 3, 5], 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this end up testing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the |
||
|
||
class Split3(Module): | ||
def forward(self, *args): | ||
return torch.split(args[0], 3, 1) | ||
|
||
class Split4(Module): | ||
def forward(self, *args): | ||
return torch.split(args[0], 4, 1) | ||
|
||
masahi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
input_data = torch.rand(input_shape).float() | ||
verify_model(Split1().float().eval(), input_data=input_data) | ||
verify_model(Split2().float().eval(), input_data=input_data) | ||
verify_model(Split3().float().eval(), input_data=input_data) | ||
verify_model(Split4().float().eval(), input_data=input_data) | ||
|
||
def test_forward_avgpool(): | ||
torch.set_grad_enabled(False) | ||
input_shape = [1, 3, 10, 10] | ||
|
@@ -1077,6 +1103,7 @@ def forward(self, xs): | |
test_forward_expand() | ||
test_forward_pow() | ||
test_forward_chunk() | ||
test_forward_split() | ||
test_upsample() | ||
test_to() | ||
test_adaptive_pool3d() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this op is splitting the index evenly, you can just provide a number of sections to split to rather than a list of indices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The split op in Relay and PyTorch have different behaviors. In Relay, if indices_or_sections is an integer, the input will be divided equally along the given axis. But in Pytorch, if split_size_or_sections is an integer type, then tensor will be split into equally sized chunks (if possible). The last chunk will be smaller if the tensor size along the given dimension dim is not divisible by split_size.