Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Bring Your Own Codegen Guide -- Part 2 #4718

Merged
merged 3 commits into from
Jan 21, 2020

Conversation

comaniac
Copy link
Contributor

@comaniac comaniac commented Jan 15, 2020

This continues #4602. Do not merge before #4602.

cc @zhiics

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome tutorial @comaniac ; really great work. I've added some comments for grammar, language.

docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
@comaniac
Copy link
Contributor Author

Thanks @tmoreau89 @zhiics for the detail review! I've addressed the comments. Please take another pass as your earliest convenience.

@comaniac comaniac marked this pull request as ready for review January 16, 2020 23:37
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac
Copy link
Contributor Author

@masahi @tqchen could you help review or merge the doc? Thanks.

docs/dev/relay_bring_your_own_codegen.rst Outdated Show resolved Hide resolved
docs/dev/relay_bring_your_own_codegen.rst Show resolved Hide resolved
@comaniac
Copy link
Contributor Author

@tqchen thanks for the review. I've addressed your comments. Please take another pass as your earliest convenience.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the changes @comaniac

@tmoreau89 tmoreau89 merged commit dcb556d into apache:master Jan 21, 2020
@tmoreau89
Copy link
Contributor

Thank you @comaniac @zhiics @tqchen the PR has been merged.

@comaniac comaniac deleted the byoc_dev_guide_part2 branch January 21, 2020 22:06
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* BYOC Tutorial -- part 2

* Fix comments

* Address comments
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* BYOC Tutorial -- part 2

* Fix comments

* Address comments
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* BYOC Tutorial -- part 2

* Fix comments

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants