-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Bring Your Own Codegen Guide -- Part 2 #4718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome tutorial @comaniac ; really great work. I've added some comments for grammar, language.
63011de
to
59d4b4c
Compare
Thanks @tmoreau89 @zhiics for the detail review! I've addressed the comments. Please take another pass as your earliest convenience. |
a35e285
to
8cb613a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tqchen thanks for the review. I've addressed your comments. Please take another pass as your earliest convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the changes @comaniac
* BYOC Tutorial -- part 2 * Fix comments * Address comments
* BYOC Tutorial -- part 2 * Fix comments * Address comments
* BYOC Tutorial -- part 2 * Fix comments * Address comments
This continues #4602. Do not merge before #4602.
cc @zhiics