Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Windows and MSVC fixes #4569

Merged
merged 3 commits into from
Dec 25, 2019
Merged

Some Windows and MSVC fixes #4569

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea7732
fix python exception creation in Windows
kice Dec 23, 2019
0e818bf
better string conversion for msvc
kice Dec 23, 2019
d0865fe
fix cpp style issue
kice Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix cpp style issue
  • Loading branch information
@kice
kice authored Dec 23, 2019
commit d0865fe265217927e389c464006355869b515014
2 changes: 1 addition & 1 deletion src/runtime/c_runtime_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ std::string NormalizeError(std::string err_msg) {
if (!(is >> line)) return false;
// get filename
while (is.peek() == ' ') is.get();
#ifdef _MSC_VER // handle volume separator ":" in Windows path
#ifdef _MSC_VER // handle volume separator ":" in Windows path
std::string drive;
if (!getline(is, drive, ':')) return false;
if (!getline(is, file_name, ':')) return false;
Expand Down