-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] add benchmark log format doc #4366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anwang2009 for the documentation on the benchmark log format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest consistency in terminology. 'engine' doesn't mean much to me as a TVM developer and I would suggest favouring intuitiveness when understanding it ?
@u99127 would be great if you can bring the proposed changes to the RFC discussion. Given that this is a proposal for standard among the community, it is important that all the field changes leaves a trace of discussion, Thanks! |
Thanks @u99127 @anwang2009 ! |
* add benchmark log format doc * code review changes * remove runtime_config, add md5 field * schema edits
* add benchmark log format doc * code review changes * remove runtime_config, add md5 field * schema edits
* add benchmark log format doc * code review changes * remove runtime_config, add md5 field * schema edits
Adds benchmark log format as discussed in
https://discuss.tvm.ai/t/rfc-benchmark-performance-log-format/4610
#4304
@tqchen
@u99127 since you expressed interest in getting your two cents in -- above github issue #4304 is more readable