-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUNTIME] Proper Device Attribute Query for AMD GPU #4305
Conversation
The error doesn't seem relevant to me, let me kick off the CI again.
|
See wiki. One architecture with different compute capabilities. |
18df399
to
60064ec
Compare
@petrex can you check indentation issues? I see some weird indentation done by clang-format. It should be consistent with the rest of the code base. |
Morning @masahi. That weird clang-format behavior was due to a missing |
The PR implements proper device queries through hip runtime API.
One primary motivation is to support devices across different architectures. Note that we had some hardcoded value before (for example, max thread per block/ warp size), which may not be optimal for the new architecture.
One minor change: replace hipGetDeviceProperties() with hipDeviceGetAttribute() for better perf.