Force code_object_v2 for amd gpu backend #4099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does v2 work on recent LLVM? |
Contributor
Author
|
code_object_v2 is still supported, although this is not the default. A side note: we are sorting out issue w.r.t to code_object_v3. At this moment, code_object_v2 would be a safer choice. |
masahi
approved these changes
Oct 11, 2019
Contributor
|
Just to add some note about the impact: This fixes the cross-thread reductions, which were broken because the code v3 objects seem to loose the fixed group segment ("shared memory") property, and reading out of bounds returns 0. |
Contributor
Author
|
yes, this is one of the motivations behind the fix. Thanks for the confirmation. |
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Oct 17, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal : Stick to code_object_v2 for LLVM AMDGPU backend at this moment.
I am taking the action item to enable code_object_v3 when it's ready and validated.