[Fix] Fix the logic of the number of nodes checking in op fusion #4074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Oct 7, 2019
MarisaKirisame
approved these changes
Oct 7, 2019
zhiics
reviewed
Oct 7, 2019
Member
zhiics
left a comment
zhiics
left a comment
There was a problem hiding this comment.
I saw the previous version would fail if we happen to stop fusing at tuples.
Contributor
|
@zhiics there is nothing special for tuple. It fail for other cases too - in mergefromto, the groups and functions that will generate is already defined, and it must merge at that point, or stuff will goes out of scope. |
Contributor
Author
|
@tqchen What kind of test case is in your mind? |
Member
|
would be great if there is a regression test that failed the case before the patch |
Contributor
Author
|
test case added @tqchen |
Member
|
Thanks everyone. This is now merged. |
zhiics
added
status: accepted
and removed
status: need test case
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Oct 17, 2019
…che#4074) * move the number of nodes constraint in op fusion up to the dom tree level * add test case of limiting the max number of ops to be fused * uncomment other test cases
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 18, 2019
…che#4074) * move the number of nodes constraint in op fusion up to the dom tree level * add test case of limiting the max number of ops to be fused * uncomment other test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the number of nodes checking in op fusion up to the dom tree level, so that the fusion won't be halted in the middle.
@MarisaKirisame @kevinthesun @zhiics