Skip to content

Revert compile_cmd kwarg name change #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 2 commits into from
Aug 12, 2019
Merged

Revert compile_cmd kwarg name change #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427876e
Revert compile_cmd kwarg name change
weberlo Aug 10, 2019
0a5545a
Fix binutil tests
weberlo Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/tvm/contrib/cc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
def create_shared(output,
objects,
options=None,
compile_cmd="g++"):
cc="g++"):
"""Create shared library.

Parameters
Expand All @@ -41,11 +41,11 @@ def create_shared(output,
options : List[str]
The list of additional options string.

compile_cmd : Optional[str]
cc : Optional[str]
The compiler command.
"""
if sys.platform == "darwin" or sys.platform.startswith("linux"):
_linux_compile(output, objects, options, compile_cmd)
_linux_compile(output, objects, options, cc)
elif sys.platform == "win32":
_windows_shared(output, objects, options)
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/python/contrib/test_binutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def make_binary():
with open(tmp_source, "w") as f:
f.write(prog)
cc.create_shared(tmp_obj, tmp_source, [],
compile_cmd="{}gcc".format(TOOLCHAIN_PREFIX))
cc="{}gcc".format(TOOLCHAIN_PREFIX))
prog_bin = bytearray(open(tmp_obj, "rb").read())
return prog_bin

Expand Down