-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APP] Android RPC #359
[APP] Android RPC #359
Conversation
@@ -0,0 +1,15 @@ | |||
<resources> | |||
<string name="app_name">TVM Rpc</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rpc->RPC
python/tvm/contrib/cc.py
Outdated
@@ -7,7 +7,8 @@ | |||
def create_shared(output, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is easier to create a ndk.py to do the actual cross compile to android? We can bundle quite a lot of things into it, like default compiler search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I created one. forgot to commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there is not too much reuse, maybe it is simpler to put the logics in ndk.py and not call create_shared here
@tqchen Ready to merge. |
python/tvm/contrib/ndk.py
Outdated
objects : list | ||
List of object files. | ||
|
||
options : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of str, optional
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
tvm.contrib.cc.create_shared
)apps/android_rpc/tests/android_rpc_test.py
)Tested on my Redmi 4X Android Phone:
Processor: AArch64 Processor rev 4 (aarch64)
GLES: Qualcomm, Adreno (TM) 505, OpenGL ES 3.1 V@145.0 (GIT@Iebe23be877)