Avoid using heavy API to query single attribution #3179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
May 13, 2019
src/runtime/cuda/cuda_device_api.cc
Outdated
| cudaDeviceProp props; | ||
| CUDA_CALL(cudaGetDeviceProperties(&props, ctx.device_id)); | ||
| *rv = std::string(props.name); | ||
| char name[256]; |
There was a problem hiding this comment.
consider directly create a std::string with the corresponding length and resize back to the size
ghostplant
force-pushed
the
avoid_prop
branch
2 times, most recently
from
1126203 to
05e872c
Compare
tqchen
requested changes
May 13, 2019
src/runtime/cuda/cuda_device_api.cc
Outdated
| cudaDeviceProp props; | ||
| CUDA_CALL(cudaGetDeviceProperties(&props, ctx.device_id)); | ||
| *rv = std::string(props.name); | ||
| std::string name(sizeof(cudaDeviceProp::name), 0); |
There was a problem hiding this comment.
consider directly use 256, note that this might cause a problem if cuda driver changes its ABI and change name to a pointer.
src/runtime/cuda/cuda_device_api.cc
Outdated
| *rv = std::string(props.name); | ||
| std::string name(sizeof(cudaDeviceProp::name), 0); | ||
| CUDA_DRIVER_CALL(cuDeviceGetName(&name[0], name.size(), ctx.device_id)); | ||
| *rv = std::string(name.c_str()); |
There was a problem hiding this comment.
name.resize(std::strlen(name.c_str())
*rv = std::move(name);
ghostplant
commented
May 14, 2019
| CUDA_DRIVER_CALL(cuDeviceGetName(&name[0], name.size(), ctx.device_id)); | ||
| name.resize(strlen(name.c_str())); | ||
| *rv = std::move(name); | ||
| return; |
tqchen
approved these changes
May 14, 2019
|
Thanks, @ghostplant ! this PR is now merged. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: Both of 2 queries spent a big stack memory and compute lots of properties unused.