Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RUST][CI] Add rust frontend tests in Jenkins" #2406

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jan 9, 2019

Reverts #2375

@tqchen tqchen merged commit 129a1c1 into master Jan 9, 2019
@tqchen
Copy link
Member Author

tqchen commented Jan 9, 2019

@ehsanmok Sorry I have to revert this PR because the new outrage it brings. After a second thought, I do think that it is possible to do rust testing in the build cpu stage. The build itself should have already provide build/lib_tvm_runtime.so . So if there is something wrong, it is unlikely has things to do with the pack library. You do not need to unpack libraries because the library is getting build in the current stage

@tqchen tqchen deleted the revert-2375-rust_runtime_frontend_ci branch January 9, 2019 18:50
@ehsanmok
Copy link
Contributor

ehsanmok commented Jan 9, 2019

Very strange! I don't know how then. I've already tried the normal frontend build at least 3 times and the CI fails due to not finding libtvm_runtime.so and thought the process should be the same as java for example. The .so is not found in LD_LIBRARY_PATH

@tqchen
Copy link
Member Author

tqchen commented Jan 9, 2019

I see, the .so is indeed not in LD_LIBRARY_PATH and they reside in root/build by default, maybe a simple change is to add root/build to LD_LIBRARY_PATH

FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Jan 10, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants