Skip to content

[REFACTOR] Move src/ir/script_printer.cc to src/script/printer/#19611

Merged
tlopex merged 1 commit into
apache:mainfrom
tqchen:tvm-relocate-script-printer-cc
May 26, 2026
Merged

[REFACTOR] Move src/ir/script_printer.cc to src/script/printer/#19611
tlopex merged 1 commit into
apache:mainfrom
tqchen:tvm-relocate-script-printer-cc

Conversation

@tqchen
Copy link
Copy Markdown
Member

@tqchen tqchen commented May 26, 2026

TVMScriptPrinter is declared in include/tvm/script/printer/config.h and its sibling helpers already live under src/script/printer/. The implementation file's location under src/ir/ was inherited from an older layout and does not match the header.

Pure relocation — no logic change. CMakeLists.txt uses an explicit file list for src/script/printer/ (not a glob), so the new path is added there as well.

Tested locally: CPU build + pytest tests/python/tvmscript/ (771 passed, 1 skipped, 1 xfailed) + pytest tests/python/relax/test_tvmscript_printer_relax.py (47 passed) + pytest tests/python/relax/distributed/test_distributed_tvmscript_printer.py (4 passed) — all pass.

TVMScriptPrinter is declared in include/tvm/script/printer/config.h
and its sibling helpers already live under src/script/printer/. The
implementation file's location under src/ir/ was inherited from an
older layout and does not match the header.

Also registers the new path in CMakeLists.txt, which uses an explicit
file list for src/script/printer/ rather than a glob.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates CMakeLists.txt to include the new source file src/script/printer/script_printer.cc in the compiler sources. There are no review comments, so I have no feedback to provide.

@tlopex tlopex merged commit 58d6a5a into apache:main May 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants