[REFACTOR] Phase out root Makefile#18828
Conversation
This PR removes the root Makefile and inlines its remaining functionality into CI scripts and READMEs. Also removes unused legacy lint scripts (pre-commit handles all linting now).
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's build and CI infrastructure by eliminating the top-level Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great refactoring that removes the root Makefile and replaces its functionality with more explicit shell commands and scripts. This improves clarity and reduces magic. The changes in the CI scripts and READMEs are mostly correct. I've found a critical issue in the updated jvm/README.md where the command for jvminstall is incorrect and will fail for many users. I've also suggested an improvement to the new task_jvm_build.sh script to make it more flexible and help resolve the README issue.
- task_jvm_build.sh now accepts an optional first arg as the Maven goal (default: "clean package"), with remaining args passed through to mvn - jvm/README.md install step updated to use task_jvm_build.sh install instead of hardcoding the linux-x86_64 profile
This PR removes the root Makefile and inlines its remaining functionality
into CI scripts and READMEs. Also removes legacy lint scripts that are
now handled by pre-commit.
Changes
Makefile— all targets either unused or inlinedtests/scripts/task_jvm_build.sh— extracted JVM platformdetection + mvn build from Makefile
task_python_docs.sh(cppdoc/javadoc),task_java_unittest.sh(jvmpkg),cppdocs.sh(doxygen)docker/README.md,jvm/README.md,apps/cpp_rpc/README.md— replacemakewith direct commandstests/lint/(8 files) —pre-commit handles all linting now
Subdirectory Makefiles (
docs/Makefile,web/Makefile) are unchanged.