Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/relax/utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,32 @@ tvm::Map<tir::Var, PrimExpr> InferSymbolicVarMap(
GetStructInfo(expr_tensor->shape.value()));
};

std::function<void(const StructInfo&, const StructInfo&)> bind_from_struct_info = nullptr;
auto bind_from_tuple = [&bind_from_struct_info](const StructInfo& var, const StructInfo& expr) {
auto var_tuple = var.as<TupleStructInfoNode>();
if (!var_tuple) return;

auto expr_tuple = expr.as<TupleStructInfoNode>();
if (!expr_tuple) return;

if (var_tuple->fields.size() != expr_tuple->fields.size()) return;

for (size_t i = 0; i < var_tuple->fields.size(); i++) {
bind_from_struct_info(var_tuple->fields[i], expr_tuple->fields[i]);
}
};

bind_from_struct_info = [&](const StructInfo& var, const StructInfo& expr) {
bind_from_tensor(var, expr);
bind_from_shape(var, expr);
bind_from_prim_value(var, expr);
bind_from_tuple(var, expr);
};

for (const auto& [relax_var, relax_expr] : relax_var_remap) {
auto var_sinfo = GetStructInfo(relax_var);
auto expr_sinfo = GetStructInfo(relax_expr);

bind_from_tensor(var_sinfo, expr_sinfo);
bind_from_shape(var_sinfo, expr_sinfo);
bind_from_prim_value(var_sinfo, expr_sinfo);
bind_from_struct_info(var_sinfo, expr_sinfo);
}

return tir_var_remap;
Expand Down
34 changes: 34 additions & 0 deletions tests/python/relax/test_transform_canonicalize_bindings.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,40 @@ def main(x: R.Tensor(("m", "n"))):
verify(TestChangeShape, Expected)


def test_replace_symbolic_variable_and_remove_match_cast_of_tuple():
"""Symbolic variables may be defined in R.match_cast of tuple

This test is similar to
`test_replace_symbolic_variable_and_remove_match_cast`, except
that the MatchCast is performed on a Relax tuple.

This is a regression test. Earlier implementations only inferred
TIR variables from `R.match_cast` of tensors, shapes, and prim
values, but omitted tuples.

"""

@I.ir_module
class Before:
@R.function
def main(x: R.Tuple(R.Tensor(("m", "n")))):
y = x
o, p = T.int64(), T.int64()
z = R.match_cast(x, R.Tuple(R.Tensor((o, p))))
w = z
q = R.add(w[0], y[0])
return R.add(q, w[0])

@I.ir_module
class Expected:
@R.function
def main(x: R.Tuple(R.Tensor(("m", "n")))):
q = R.add(x[0], x[0])
return R.add(q, x[0])

verify(Before, Expected)


def test_unwrap_tuple():
@I.ir_module
class Before:
Expand Down