[RUNTIME] Ensure NDArray.CopyTo(Device) always sync #16716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that NDArray.CopyTo(Device) always sync. Prior to this PR, the behavior is uncertain as the underlying DeviceAPI may or maynot sync. This PR further clarifies in docs about the contract (that low-level device api is always async) as well as the sync/async nature of each NDArray API.
vinx13
approved these changes
Mar 13, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
This PR ensures that NDArray.CopyTo(Device) always sync. Prior to this PR, the behavior is uncertain as the underlying DeviceAPI may or maynot sync. This PR further clarifies in docs about the contract (that low-level device api is always async) as well as the sync/async nature of each NDArray API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that NDArray.CopyTo(Device) always sync.
Prior to this PR, some of the behavior relied on undefined behavior, as the per convention the underlying DeviceAPI may be async, but due to the cuda implementations was sync, we implicitly relied on that behavior.
This PR further clarifies in docs about the contract (that low-level device api is always async) as well as the sync/async nature of each NDArray API.