-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity] Set CMAKE_CUDA_ARCHITECTURES default to native #16335
Conversation
I like the change, and this makes sense to me. |
Since #16302 passed CI, and is now merged in as a temporary fix, can this PR also revert the changes from it? |
621fc09
to
47a3c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, and for handling the changes between TVM and the cutlass kernels!
113f38d
to
1d600da
Compare
Late to the party but just wanted to say i love this change. Thanks Wuwei! |
It looks like cmake's GPU detection isn't perfect (tested with cmake
I don't have a good long-term solution for this issue, but a current workaround is to explicitly call |
CI images should also be updated to install cmake 3.24
cc @tqchen @junrushao @Lunderberg