Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity] Set CMAKE_CUDA_ARCHITECTURES default to native #16335

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Jan 2, 2024

CI images should also be updated to install cmake 3.24

cc @tqchen @junrushao @Lunderberg

@Lunderberg
Copy link
Contributor

I like the change, and this makes sense to me.

@Lunderberg
Copy link
Contributor

Since #16302 passed CI, and is now merged in as a temporary fix, can this PR also revert the changes from it?

@vinx13 vinx13 marked this pull request as ready for review January 9, 2024 16:55
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, and for handling the changes between TVM and the cutlass kernels!

@junrushao junrushao merged commit 474c06b into apache:unity Jan 10, 2024
13 of 14 checks passed
@jwfromm
Copy link
Contributor

jwfromm commented Jan 11, 2024

Late to the party but just wanted to say i love this change. Thanks Wuwei!

@Lunderberg
Copy link
Contributor

It looks like cmake's GPU detection isn't perfect (tested with cmake 3.26.4 and 3.27.7), and this can cause the following error to occur when trying to determine the cuda architectures to use.

CMake Error in CMakeLists.txt:                                    
  CUDA_ARCHITECTURES is set to "native", but no GPU was detected. 

I don't have a good long-term solution for this issue, but a current workaround is to explicitly call set(CMAKE_CUDA_ARCHITECTURES 75) in your config.cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants