Skip to content

[Device][Metal] Fix metal warp size #16192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junrushao merged 3 commits into from
Dec 2, 2023
Merged

[Device][Metal] Fix metal warp size #16192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
534a8cf
fix metal warp size
jinhongyii Dec 1, 2023
124b736
fix
jinhongyii Dec 1, 2023
66a19ce
change fatal to warning
jinhongyii Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/runtime/metal/metal_device_api.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,14 @@
break;
}
case kWarpSize: {
// Set warp size to be 1 for safty reason.
#if defined(__x86_64__)
*rv = 1;
#elif defined(__aarch64__)
*rv = 32;
#else
LOG(WARNING) << "The CPU architecture is neither x86 nor aarch64. Fallback to warp size 1.";
*rv = 1;
#endif
break;
}
case kMaxSharedMemoryPerBlock:
Expand Down