[microNPU][ETHOSU] Fix rounding mode in requantize operation #15929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, TFL rounding was used in the requantize operation and this led to a discrepancy in the results in some cases
lhutton1
approved these changes
Oct 16, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
LGTM, thanks @Aleksei-grovety!
ysh329
pushed a commit
to ysh329/tvm
that referenced
this pull request
Oct 18, 2023
…15929) Before the fix, TFL rounding was used in the requantize operation and this led to a discrepancy in the results in some cases
Hzfengsy
pushed a commit
that referenced
this pull request
Oct 18, 2023
…tion (#15929) (#15946) [microNPU][ETHOSU] Fix rounding mode in requantize operation (#15929) Before the fix, TFL rounding was used in the requantize operation and this led to a discrepancy in the results in some cases Co-authored-by: Aleksei-grovety <113356454+Aleksei-grovety@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, TFL rounding was used in the requantize operation, and this led to a discrepancy in the results in some cases.
cc @lhutton1, @ekalda, @leandron