[TIR] Do not drop 4th argument to tir.max #15763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tir.op.comm_reducer` utility provides two distinct APIs, either reducing along a tensor axis or reducing along a list of arguments. Prior to this commit, when reducing along a list of arguments, the 4th argument was silently dropped. For example, `tvm.tir.max(1,2,3,4,3,2,1)` would return `3`.
csullivan
approved these changes
Sep 15, 2023
Hzfengsy
approved these changes
Sep 16, 2023
junrushao
approved these changes
Sep 16, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
This is great addition! Thanks for the work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tir.op.comm_reducerutility provides two distinct APIs, either reducing along a tensor axis or reducing along a list of arguments.Prior to this commit, when reducing along a list of arguments, the 4th argument was silently dropped. For example,
tvm.tir.max(1,2,3,4,3,2,1)would return3.