Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity] Prevent Relax VM from being corrupted after getting incorrect shape #15612

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

yelite
Copy link
Contributor

@yelite yelite commented Aug 23, 2023

@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@yelite yelite changed the title [Unity] Prevent VM stack frames from being corrupted after getting incorrect shape [Unity] Prevent Relax VM from being corrupted after getting incorrect shape Aug 23, 2023
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea to guard the frames in case of any exceptions thrown!

Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to have this fixed. Thank you Lite!

@Hzfengsy Hzfengsy merged commit 619cbec into apache:unity Aug 24, 2023
3 of 4 checks passed
guoyaol added a commit to guoyaol/tvm that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants