-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix Cython compile for v3.0.0 release #15346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
Windows and MacOS builds are failing as they use cython==0.29.24 and cython==0.29.28 respectively, which are not compatible with the new |
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_python. Pinning the cython version until a working fix is created. Posting this PR as an alternative to apache#15346. Change-Id: Id817aea375e1ed84c807c265ca4cc42c1757bca0
|
My guess would be that because the Conda build uses tvm/conda/build-environment.yaml Line 28 in e2d6511
That may be quite concerning given |
|
We can remove the 3.7 here from tehe build env |
|
Let's get this PR merged instead! |
|
After updating the python version to 3.8, the same issues mentioned in #15346 (comment) seem to persist For MacOS (I didn't check windows yet), it seems there are updated cython packages available on this channel https://repo.anaconda.com/pkgs/main/osx-64/ for python 3.8, but conda seems to prefer fetching packages from a different outdated channel (https://conda.anaconda.org/anaconda/osx-64/), I'm a little bit lost here.. |
Cython `v3.0.0` was recently released (https://github.com/cython/cython/releases/tag/3.0.0) and is used in newly built docker images. This causes a compilation issue since 3.0.0 expects function definitions to be explicitly declared with the `noexcept` annotation. This change should be backwards compatible to `v0.29.*`. For more details see the discussion here: scipy/scipy#17234 (comment). Change-Id: Ic252ddfb4262a3b0fffe93c5ca4b9729bf167e05
Upgrades the python version from 3.7 to 3.8 to use newer versions of cython. Change-Id: Id5e280eebaae1d367774ad0952234a1458cc1c33
Change-Id: I67c8342dc963b4b8e955aede9282551297be0c14
Change-Id: I01b60b5ff5e6ba8df4e1afdd5ff931ae7dd77775
|
I've tried reproducing the conda environment used for MacOS locally with this patch checked out, although I've been unable to recreate the same failure. The latest version of cython |
|
#15469 likely supersedes this. We can still work to upgrade the python conda versions to 3.8 or later |
Cython
v3.0.0was recently released (https://github.com/cython/cython/releases/tag/3.0.0) and is used in newly built docker images. This causes a compilation issue since 3.0.0 expects function definitions to be explicitly declared with thenoexceptannotation. This change should be backwards compatible tov0.29.31. For more details see the discussion here: scipy/scipy#17234 (comment).