[CUDA][CodeGen] Fix cuda codegen's fp16 inf literal #12581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
approved these changes
Aug 24, 2022
Member
|
cc @shingjan |
shingjan
reviewed
Aug 24, 2022
| case 16: { | ||
| os << "__float2half_rn"; | ||
| os << '(' << std::scientific << op->value << 'f' << ')'; | ||
| os << "__float2half_rn" << '('; |
There was a problem hiding this comment.
Would that be possible that some tests are added? We can probably re-use my repro here
Contributor
Author
There was a problem hiding this comment.
the case is added
wrongtest-intellif
force-pushed
the
fix_cuda_fp16_inf_literal
branch
from
c04edc7 to
2614cb1
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* Fix cuda codegen's fp16 inf literal * add relay testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fix #12566