[Relay] Allow partial virtual device annotations. #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously CompilationConfig::CanonicalVirtualDevice required the argument virtual device to contain a device type. However now that virtual devices may contain memory scopes that's unnecessarily strict. With this change it is possible to write virtual device annotations with just memory scopes, and let PlanDevices flow those constraints along with the usual device constraints.
driazati
approved these changes
Jul 15, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [Relay] Allow partial virtual device annotations. Previously CompilationConfig::CanonicalVirtualDevice required the argument virtual device to contain a device type. However now that virtual devices may contain memory scopes that's unnecessarily strict. With this change it is possible to write virtual device annotations with just memory scopes, and let PlanDevices flow those constraints along with the usual device constraints. * - Make sure CanonicalVirtualDevice reuses FullyUnconstrained
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [Relay] Allow partial virtual device annotations. Previously CompilationConfig::CanonicalVirtualDevice required the argument virtual device to contain a device type. However now that virtual devices may contain memory scopes that's unnecessarily strict. With this change it is possible to write virtual device annotations with just memory scopes, and let PlanDevices flow those constraints along with the usual device constraints. * - Make sure CanonicalVirtualDevice reuses FullyUnconstrained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously CompilationConfig::CanonicalVirtualDevice required
the argument virtual device to contain a device type. However
now that virtual devices may contain memory scopes that's
unnecessarily strict.
With this change it is possible to write virtual device
annotations with just memory scopes, and let PlanDevices
flow those constraints along with the usual device constraints.