[MetaSchedule] Enable Task Filtering #11512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
Can we add testcases? |
Member
Author
|
@Hzfengsy thanks for asking! It's pretty hard to add a unittest given we will need an actual end-to-end network that takes hours to run...In this particular case, it might be good to leave it to future integration test instead |
Hzfengsy
approved these changes
May 31, 2022
comaniac
approved these changes
May 31, 2022
Contributor
There was a problem hiding this comment.
IIUC, unit tests for task extraction don't need to run tune. Instead, it only needs to extract tasks and verify their number and workloads. However, if MetaSchedule doesn't have unit tests for task extractions yet, we could of course add it later.
Member
Author
|
I'm happy to add a simple unittest without tuning :-) |
junrushao
force-pushed
the
feature/2022-05-30/task-filtering
branch
from
16a8851 to
5f96e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
relay.backend.MetaScheduleExtractTaskto take an extra argumentfilter_funcwhich filters out tasks that don't need tuning. The counterpart of AutoScheduler istraverse_to_get_io_tensors.