Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Added message if test is running on another shard #11331

Merged
merged 1 commit into from
May 18, 2022

Conversation

Lunderberg
Copy link
Contributor

@Lunderberg Lunderberg commented May 16, 2022

Previously, these tests were labeled as "unconditional skip" in the CI logs (e.g. here), which can cause confusion during debugging.

cc @Mousius @areusch @driazati

@Lunderberg Lunderberg requested a review from driazati May 16, 2022 21:29
@Lunderberg
Copy link
Contributor Author

@mehrdadh Related to our discussion on #11294

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nice UX improvement, thanks!

@Lunderberg Lunderberg force-pushed the shard_skip_message branch from 2fbd4c4 to 2a0fab8 Compare May 17, 2022 00:56
@github-actions github-actions bot requested review from Mousius and areusch May 17, 2022 00:56
@areusch areusch merged commit 3fbd9b6 into apache:main May 18, 2022
@Lunderberg Lunderberg deleted the shard_skip_message branch May 18, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants