[Hexagon] Replace strlen in constant initialization with sizeof #10381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
requested review from
ZihengJiang,
areusch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
tqchen and
vinx13
as code owners
Strlen is not constexpr everywhere, so replace it with sizeof.
In C++ sizeof("string") works fine, since "string" has type
"const char [...]".
masahi
approved these changes
Feb 25, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…he#10381) Strlen is not constexpr everywhere, so replace it with sizeof. In C++ sizeof("string") works fine, since "string" has type "const char [...]".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strlen is not constexpr everywhere, so replace it with
sizeof. In C++sizeof("string")works fine, since"string"has type"const char [...]".