Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Unnecessary highlighted boxes in the documentation #13668

Open
padreofthegame opened this issue Dec 28, 2022 · 1 comment
Open

[Docs] Unnecessary highlighted boxes in the documentation #13668

padreofthegame opened this issue Dec 28, 2022 · 1 comment
Assignees

Comments

@padreofthegame
Copy link
Contributor

Documentation Title & Type

While looking into documentation related to working with pre-quantized models I observed few maybe minor issues, related to doc appearance in the web browser, mentioned below:

  • Deploy a Framework-prequantized Model with TVM
    • Looks like there is an unnecessary highlighted block at the beginning of the document,
    • At the bottom of the doocument looks like the TODO comment for TFLite model is obsolete since it is solved on the next page.
    • It would also be good to have uniform title convention for different frontends as in Compile Deep Learning Models part (for example, Deploy a Framework-prequantized Model with TVM - PyTorch, Deploy a Framework-prequantized Model with TVM - TFLite, etc...)
  • Deploy a Framework-prequantized Model with TVM - Part 3 (TFLite)
    • Unnecessary highlighted block at the beginning of the document.
    • Maybe discard Part 3 in the title of the document and just put TFLite without brackets on its place.

Also I get through all documentation pages, and found occurrence of similar highlighted box, mostly at the beginning of the document, in the following pages:

cc @areusch @driazati

@padreofthegame padreofthegame added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: doc labels Dec 28, 2022
@driazati driazati removed the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Dec 29, 2022
@driazati driazati self-assigned this Dec 29, 2022
@driazati
Copy link
Member

Thanks for reporting this! #13188 was supposed to fix the boxes but it looks like that didn't catch all the cases.

driazati added a commit to driazati/tvm that referenced this issue Jan 3, 2023
This fixes some of the issues highlighted in apache#13668, the parser that
checks to ensure that the hidden import is placed in the right spot was
incorrect, this includes some fixes to get it working for the cases in
that issue.
driazati added a commit to driazati/tvm that referenced this issue Jan 4, 2023
This fixes some of the issues highlighted in apache#13668, the parser that
checks to ensure that the hidden import is placed in the right spot was
incorrect, this includes some fixes to get it working for the cases in
that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants